/claim #8157 chore: update project configuration for testing and Docker setup#8375
Closed
matiasmagni wants to merge 1 commit intocoollabsio:v4.xfrom
Closed
/claim #8157 chore: update project configuration for testing and Docker setup#8375matiasmagni wants to merge 1 commit intocoollabsio:v4.xfrom
matiasmagni wants to merge 1 commit intocoollabsio:v4.xfrom
Conversation
- Added Playwright and PEST configurations to .gitignore and composer.json for improved testing. - Updated docker-compose.dev.yml to include Playwright service for end-to-end testing. - Enhanced test scripts in package.json for better test execution. - Made minor adjustments to InstallDocker and InstallPrerequisites for better OS compatibility. - Refactored tests to ensure proper setup and execution, including InstanceSettings initialization.
algora-pbc
bot
added
the
🙋 Bounty claim
github-actions
bot
added
quality/rejected
and removed
🙋 Bounty claim
Contributor
|
This PR did not pass quality checks so it will be closed. If you believe this is a mistake please let us know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/claim #8157
Changes
app/Models/Server.php): Added Debian 13 (Trixie) support by includingtrixiein the list of recognized Debian version codenames. When/etc/os-releasehas an empty or missingIDbutVERSION_CODENAMEis a known Debian codename (stretch, buster, bullseye, bookworm, trixie),IDis set todebianso the server is accepted. Tightened parsing of/etc/os-release(skip empty/invalid lines) and madevalidateOS()return the matching SUPPORTED_OS string consistently.getDebianDockerInstallCommand()that the fallback usesVERSION_CODENAME(e.g. trixie) for the Docker APT suite so all Debian versions, including 13, are supported.tests/Unit/ServerValidateOsSupportTest.phpasserting that SUPPORTED_OS includes the debian family and that the Debian codename list used invalidateOS()includestrixieandbookworm.Issues
Category
Screenshots or Video (if applicable)
N/A – backend validation only. Optional: screen recording of adding a Debian 13 server and running "Install Prerequisites" / Docker install without "Unsupported OS type" error.
AI Usage
Steps to Test
./vendor/bin/pest tests/Unit/ServerValidateOsSupportTest.php. Expect 2 tests, 4 assertions, all passing.deb [arch=...] https://download.docker.com/linux/debian trixie stable).Contributor Agreement
Important