feat(server): add Debian 13 (Trixie) support for server validation#8437
Closed
matiasmagni wants to merge 2 commits intocoollabsio:v4.xfrom
Closed
feat(server): add Debian 13 (Trixie) support for server validation#8437matiasmagni wants to merge 2 commits intocoollabsio:v4.xfrom
matiasmagni wants to merge 2 commits intocoollabsio:v4.xfrom
Conversation
- Extend Server::validateOS() to recognize Debian 13 by adding 'trixie' to the Debian version codename list (stretch, buster, bullseye, bookworm, trixie). When /etc/os-release has an empty or missing ID but VERSION_CODENAME is a known Debian codename, ID is set to 'debian' so the server is accepted. - InstallPrerequisites: Added explicit Alpine Linux branch with clear error message instead of generic 'Unsupported OS type'. - InstallDocker: Documented that the Debian fallback uses VERSION_CODENAME (e.g. trixie for Debian 13) for the Docker APT suite, so all Debian versions are supported. - Add ServerValidateOsSupportTest to assert SUPPORTED_OS includes the debian family and that the Debian codename list includes trixie (and bookworm). Fixes coollabsio#8154
- Added patterns for various temporary files, cache directories, and system-specific files to improve project cleanliness and prevent unnecessary files from being tracked.
Contributor
|
This PR did not pass quality checks so it will be closed. If you believe this is a mistake please let us know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
app/Models/Server.php): Added Debian 13 (Trixie) support by includingtrixiein the list of recognized Debian version codenames. When/etc/os-releasehas an empty or missingIDbutVERSION_CODENAMEis a known Debian codename (stretch, buster, bullseye, bookworm, trixie),IDis set todebianso the server is accepted. Tightened parsing of/etc/os-release(skip empty/invalid lines) and madevalidateOS()return the matching SUPPORTED_OS string consistently.getDebianDockerInstallCommand()that the fallback usesVERSION_CODENAME(e.g. trixie) for the Docker APT suite so all Debian versions, including 13, are supported.tests/Unit/ServerValidateOsSupportTest.phpasserting that SUPPORTED_OS includes the debian family and that the Debian codename list used invalidateOS()includestrixieandbookworm.Issues
Category
Screenshots or Video (if applicable)
N/A – backend validation only. Optional: screen recording of adding a Debian 13 server and running "Install Prerequisites" / Docker install without "Unsupported OS type" error.
AI Usage
Steps to Test
./vendor/bin/pest tests/Unit/ServerValidateOsSupportTest.php. Expect 2 tests, 4 assertions, all passing.deb [arch=...] https://download.docker.com/linux/debian trixie stable).Contributor Agreement
Important