fix(server): improve debian-like detection and alpine install flow#8485
Closed
1312e wants to merge 2 commits intocoollabsio:nextfrom
Closed
fix(server): improve debian-like detection and alpine install flow#84851312e wants to merge 2 commits intocoollabsio:nextfrom
1312e wants to merge 2 commits intocoollabsio:nextfrom
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
Author
|
更正(上条评论被 shell 转义污染,这条为准):
说明:本 PR 为 server 修复项,不属于 one-click service 文档范围。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
ID_LIKEfallback path inServer::resolveSupportedOsTypeso Debian-family derivatives can be detected reliably.apk update+ required packages).systemctl,rc-service, andservicebased systems.Issues
Category
Screenshots or Video (if applicable)
AI Usage
Steps to Test
php -l app/Models/Server.php app/Actions/Server/InstallPrerequisites.php app/Actions/Server/InstallDocker.phpand verify there are no syntax errors.php -l tests/Unit/ServerResolveSupportedOsTypeTest.php tests/Unit/Actions/Server/InstallDockerAlpineCommandTest.php.Contributor Agreement
Important