fix: add --volume support to convertDockerRunToCompose#8923
Open
sudee404 wants to merge 1 commit intocoollabsio:nextfrom
Open
fix: add --volume support to convertDockerRunToCompose#8923sudee404 wants to merge 1 commit intocoollabsio:nextfrom
sudee404 wants to merge 1 commit intocoollabsio:nextfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
--volumeflags in Custom Docker Run Options are silently ignored becauseconvertDockerRunToCompose()has no mapping for them. This adds--volumeto$list_options,$mapping, and a handler block so that volume bind mounts specified via Custom Docker Run Options are correctly included in the generated docker-compose config.Issues
Category
AI Assistance
If AI was used:
Testing
Tested on a live Coolify v4.0.0-beta.460 instance:
--volume /opt/data/logs:/app/logs --volume /opt/data/tracking:/app/trackingdocker inspectshowsMounts: []docker inspectshows both bind mounts appliedconvertDockerRunToCompose()directly returns['volumes' => ['/opt/data/logs:/app/logs', '/opt/data/tracking:/app/tracking']]Contributor Agreement
Important