Skip to content

fix(deployment): resolve intermittent pre-deployment command failures#9165

Merged
andrasbacsai merged 2 commits intonextfrom
9076-investigate-pre-deployment
Mar 31, 2026
Merged

fix(deployment): resolve intermittent pre-deployment command failures#9165
andrasbacsai merged 2 commits intonextfrom
9076-investigate-pre-deployment

Conversation

@andrasbacsai
Copy link
Copy Markdown
Member

Summary

  • Extract container resolution logic into a dedicated resolveCommandContainer() method used by both pre- and post-deployment commands
  • Fix intermittent "Could not find a valid container" failures by making container selection deterministic
  • Improve error messages to list available containers when resolution fails, aiding debugging
  • Add comprehensive test coverage (9 test cases) for single-container, multi-container, and edge cases
  • Add informative logging when no containers are running or when container name is missing for multi-container apps

Breaking Changes

None. The error message format changes slightly to include available container names, but the exception type and behavior remain the same.


Fixes #9076

…mands

Extract common container selection logic into resolveCommandContainer() method
that handles both single and multi-container app scenarios. This consolidates
duplicated code from run_pre_deployment_command() and run_post_deployment_command()
while improving error messaging and test coverage.
@andrasbacsai andrasbacsai merged commit c1d670b into next Mar 31, 2026
3 checks passed
@andrasbacsai andrasbacsai deleted the 9076-investigate-pre-deployment branch March 31, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant