refactor(chat): consolidate slash command execution into message pipeline#230
Open
andrasbacsai wants to merge 4 commits intomainfrom
Open
refactor(chat): consolidate slash command execution into message pipeline#230andrasbacsai wants to merge 4 commits intomainfrom
andrasbacsai wants to merge 4 commits intomainfrom
Conversation
- Extract pending commands state to Zustand store for session-based tracking - Move command execution logic from usePendingAttachments to useMessageSending - Simplify usePendingAttachments hook to focus on attachment removal - Remove onCommandExecute callback from ChatInput and ChatWindow components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/commandnameinstead of executing immediately, allowing users to provide argumentspendingCommandsstate to chat store to track selected command per sessionusePendingAttachmentshook by removing command execution logicChanges by File
ChatInput.tsx: Refactor command selection to insert into input rather than execute; auto-detect command when user types space after command name; clear pending command when input changes.
useMessageSending.ts: Add command resolution logic to
handleSubmit; when a pending command exists, resolve it asynchronously and send resolved content plus user arguments as the message.usePendingAttachments.ts: Remove
handleCommandExecuteand associated parameters; simplify to only handle attachment removal and queue management.ChatWindow.tsx: Remove
onCommandExecuteprop from ChatInput; pass only essential parameters tousePendingAttachments.chat-store.ts: Add
pendingCommandsstate andsetPendingCommandaction to track slash commands per session.