Make languages default to english with missing data#1140
Open
EmeraldLoc wants to merge 4 commits intocoop-deluxe:devfrom
Open
Make languages default to english with missing data#1140EmeraldLoc wants to merge 4 commits intocoop-deluxe:devfrom
EmeraldLoc wants to merge 4 commits intocoop-deluxe:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Really just title. Tested by nuking half the Spanish language, it indeed works. Nothing that complicated here, just gonna add a bunch of stuff here ig...
This pr is a massive quality of life change and a huge codebase change. Lots was done to make this pull request happen, This pr does a complete language refactor, allowing for multiple new languages, new systems, and more! Changing a language means all words in the game get changed, every single one! With the old system only some words were translated, now they all are! I know this may not seem that great, but it is truly something special. This pr is something that every bilingual person should enjoy, I don't even speak any other languages and I love this change! This refactor will be an extremely life changing pr, that includes not only language changes, but word changes, and backend changes, and code changes, safety changes, management changes, and more! This is great, a wonderful showcase of what human engineering can do, a showcase of the ability to gain motivation to code truly great things. This is easily the biggest pr I've done. It's like it halo 2 and animal crossing were combined. This pr also allows the language to fall back. This is huge. Have you ever wanted something to fall back on? Languages have that privilege, a privilege indeed, caused by true creativity. This pr truly is one of the greatest. It can even load 2 languages in parallel, that's how you know it's good! Please merge like right now because this pr is the undeniable GOAT. Thank you for reading this, this pr means so much to me, and it would mean the world if it got merged right now. Thank you, have a wonderful, amazing, great, incredible, super night. Keep playing Mario 64, keep coding, keep gaming, and for my signature, my amazing signature. I will give it, as it's such an amazing thing. The way the words are inserted onto the page is unbelievable, here it is, it's coming, get ready, here it comes!