Mark all unused variables as unused, resolve other warnings#1147
Open
EmeraldLoc wants to merge 2 commits intocoop-deluxe:devfrom
Open
Mark all unused variables as unused, resolve other warnings#1147EmeraldLoc wants to merge 2 commits intocoop-deluxe:devfrom
EmeraldLoc wants to merge 2 commits intocoop-deluxe:devfrom
Conversation
…hings still need to be looked at
Contributor
|
If I were you I would just deleted the unused variables and other data but this is probably a better approach than nuking all of it |
Contributor
Author
|
I don't mind doing so, I was cautious on deleting anything that seemed like it could ever come back to life, but I could probably do another pass and delete more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was getting annoyed at the obnoxious amount of "Warning: Unused variable" garbage I would get during compilation. So I marked them all as unused. For the most part these changes should be fine, but I did end up altering an
sprintfinstb_image_write.h, as it was marked as unsafe by the compiler. It was an easy fix, but because it's a lib like that, I thought I'd mention it. (Also, I don't think I'm actually meant to be getting unused variable warnings lol, but on macOS the flag isn't being set ¯_(ツ)_/¯, well, at least it let me do this).