Skip to content

Conversation

@JinZhou5042
Copy link
Member

Proposed Changes

Task priorities can differ by several orders of magnitude, so increasing them by a fixed number internally would be meaningless. Instead, we should scale the priorities multiplicatively to preserve their relative magnitude.

Merge Checklist

The following items must be completed before PRs can be merged.
Check these off to verify you have completed all steps.

  • make test Run local tests prior to pushing.
  • make format Format source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)
  • make lint Run lint on source code prior to pushing.
  • Manual Update: Update the manual to reflect user-visible changes.
  • Type Labels: Select a github label for the type: bugfix, enhancement, etc.
  • Product Labels: Select a github label for the product: TaskVine, Makeflow, etc.
  • PR RTM: Mark your PR as ready to merge.

@JinZhou5042 JinZhou5042 self-assigned this Nov 3, 2025
@btovar
Copy link
Member

btovar commented Nov 4, 2025

I think this is the wrong approach. The objective of the increase in priority is to run the task sooner, and the * 1.05 does not guarantee it. It is easy to set priorities far apart that the issue does not go away. I suggest coming up with a different policy (like having two tasks priorities: user and taskvine and sort first by the taskvine priorities. The priority queue would look at two priorities.)

Because of this, I'm reluctant to merge this one.

@btovar
Copy link
Member

btovar commented Nov 4, 2025

I can give the two priorities idea a try tomorrow.

@JinZhou5042
Copy link
Member Author

Handled in #4273

@JinZhou5042 JinZhou5042 closed this Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants