Skip to content

vine: don't print Submitted recovery task xxx to terminal #4264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

vine: don't print Submitted recovery task xxx to terminal #4264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c601924
vine: don't print Submitted recovery xxx on terminal
Nov 3, 2025
6f6b15c
trigger rebuild
Nov 3, 2025
094c18a
use stats
Nov 5, 2025
9ff1636
restore
Nov 5, 2025
73f25e2
no factory display
Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions taskvine/src/bindings/python3/ndcctools/taskvine/display.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,7 @@ def generate_manager_table(self, manager_s):
"tasks_done",
"tasks_waiting",
"tasks_running",
"recovery_tasks_submitted",
"tasks_exhausted_attempts",
"workers_connected",
"workers_busy",
Expand Down
1 change: 1 addition & 0 deletions taskvine/src/manager/taskvine.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@ struct vine_stats {
int tasks_on_workers; /**< Number of tasks currently dispatched to some worker. */
int tasks_running; /**< Number of tasks currently executing at some worker. */
int tasks_with_results; /**< Number of tasks with retrieved results and waiting to be returned to user. */
int recovery_tasks_submitted; /**< Total number of recovery tasks submitted since the manager started. */

/* Cumulative stats for tasks: */
int tasks_submitted; /**< Total number of tasks submitted to the manager. */
Expand Down
6 changes: 4 additions & 2 deletions taskvine/src/manager/vine_manager.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2262,6 +2262,7 @@ static struct jx *manager_to_jx(struct vine_manager *q)
jx_insert_integer(j, "tasks_on_workers", info.tasks_on_workers);
jx_insert_integer(j, "tasks_running", info.tasks_running);
jx_insert_integer(j, "tasks_with_results", info.tasks_with_results);
jx_insert_integer(j, "recovery_tasks_submitted", info.recovery_tasks_submitted);
jx_insert_integer(j, "tasks_left", q->num_tasks_left);

jx_insert_integer(j, "tasks_submitted", info.tasks_submitted);
Expand Down Expand Up @@ -3519,7 +3520,7 @@ static void vine_manager_consider_recovery_task(struct vine_manager *q, struct v
case VINE_TASK_INITIAL:
/* The recovery task has never been run, so submit it now. */
vine_submit(q, rt);
notice(D_VINE, "Submitted recovery task %d (%s) to re-create lost temporary file %s.", rt->task_id, rt->command_line, lost_file->cached_name);
debug(D_VINE, "Submitted recovery task %d (%s) to re-create lost temporary file %s.", rt->task_id, rt->command_line, lost_file->cached_name);
break;
case VINE_TASK_READY:
case VINE_TASK_RUNNING:
Expand All @@ -3533,7 +3534,7 @@ static void vine_manager_consider_recovery_task(struct vine_manager *q, struct v
* here. */
vine_task_reset(rt);
vine_submit(q, rt);
notice(D_VINE, "Submitted recovery task %d (%s) to re-create lost temporary file %s.", rt->task_id, rt->command_line, lost_file->cached_name);
debug(D_VINE, "Submitted recovery task %d (%s) to re-create lost temporary file %s.", rt->task_id, rt->command_line, lost_file->cached_name);
break;
}
}
Expand Down Expand Up @@ -4869,6 +4870,7 @@ int vine_submit(struct vine_manager *q, struct vine_task *t)
* this distinction is important when many files are lost and the workflow is effectively rerun from scratch. */
if (t->type == VINE_TASK_TYPE_RECOVERY) {
vine_task_set_priority(t, t->priority + priority_queue_get_top_priority(q->ready_tasks) + 1);
q->stats->recovery_tasks_submitted++;
}

if (t->has_fixed_locations) {
Expand Down