Skip to content

Conversation

@JinZhou5042
Copy link
Member

@JinZhou5042 JinZhou5042 commented Nov 3, 2025

Proposed Changes

A new paramer to let users choose whether to handle recovery tasks.

False is default. When set to true, the user explicitly opts to manage the completion recovery tasks.

Use case: We want to prune files created by recovery tasks. File pruning must be handled at the graph executor, which decides what files to delete when a task completes. The current implementation does not respect data produced by recovery tasks because they are implicitly skipped when complete.

Merge Checklist

The following items must be completed before PRs can be merged.
Check these off to verify you have completed all steps.

  • make test Run local tests prior to pushing.
  • make format Format source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)
  • make lint Run lint on source code prior to pushing.
  • Manual Update: Update the manual to reflect user-visible changes.
  • Type Labels: Select a github label for the type: bugfix, enhancement, etc.
  • Product Labels: Select a github label for the product: TaskVine, Makeflow, etc.
  • PR RTM: Mark your PR as ready to merge.

@JinZhou5042 JinZhou5042 self-assigned this Nov 3, 2025
@dthain dthain self-requested a review November 4, 2025 18:21
@JinZhou5042
Copy link
Member Author

RTM

Copy link
Member

@btovar btovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the taskvine manual, with a note that this is not expected to be used in regular applications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants