-
Notifications
You must be signed in to change notification settings - Fork 124
vine: vine_temp.c #4269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JinZhou5042
wants to merge
15
commits into
cooperative-computing-lab:master
Choose a base branch
from
JinZhou5042:vine_temp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
vine: vine_temp.c #4269
JinZhou5042
wants to merge
15
commits into
cooperative-computing-lab:master
from
JinZhou5042:vine_temp
+467
−99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 5, 2025
btovar
approved these changes
Nov 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ready to merge?
|
I see you included the cleanup of redundant replicas. We should find a way so that the redundant tasks are not created. |
|
Could you elaborate a bit on what redundant tasks refer to? |
|
Sorry, I misunderstood the source! Once you fix the conflicts I can merge this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR includes the following features:
vine_temp.c, which controls file replication, redundancy cleanup, and disk load shifting.temp_files_to_replicateis turned into a priority queue, files with least replicas are considerred first to replicate.vine_prunewill not trigger the removal of a record intemp_files_to_replicate, which makes the data pruning faster, the replication will fail silently if no available replicas.Merge Checklist
The following items must be completed before PRs can be merged.
Check these off to verify you have completed all steps.
make testRun local tests prior to pushing.make formatFormat source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lintRun lint on source code prior to pushing.