vine: make evicting a randome worker a function #4271
+48
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btovar
requested changes
Nov 5, 2025
| } | ||
|
|
||
| /** Evict a random worker to simulate a failure. */ | ||
| int vine_manager_evict_a_random_worker(struct vine_manager *q) |
There was a problem hiding this comment.
Let's all it release_random_worker. Eviction means to kick off a worker from a compute node.
| struct list *candidates_list = list_create(); | ||
| char *key; | ||
| struct vine_worker_info *w; | ||
| HASH_TABLE_ITERATE(q->worker_table, key, w) |
There was a problem hiding this comment.
There is hash table random start. You can use it instead of creating a list of all the workers, which could be expensive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Modulize the function of evicting a random worker and expose this API.
The upper level executor can determine the eviction policy, either static, executed at fixed time intervals, or dynamic, driven by workflow completion progress.
Merge Checklist
The following items must be completed before PRs can be merged.
Check these off to verify you have completed all steps.
make testRun local tests prior to pushing.make formatFormat source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lintRun lint on source code prior to pushing.