Skip to content

fix: check unref before calling #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nomagick wants to merge 3 commits into
base: master
Choose a base branch
from
+13 −4
Open

fix: check unref before calling #304

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f127373
fix: check unref before calling
nomagick May 22, 2023
0b18db9
fix: missing semicolon
nomagick May 22, 2023
2fa71ba
Fix typo
nomagick May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions lib/Pool.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,9 +152,14 @@ class Pool extends EventEmitter {

_applyDestroyTimeout(promise) {
const timeoutPromise = new this._Promise((resolve, reject) => {
setTimeout(() => {
const timer = setTimeout(() => {
reject(new Error("destroy timed out"));
}, this._config.destroyTimeoutMillis).unref();
}, this._config.destroyTimeoutMillis);

// Only relevant in Node.js and for process quitting
if (typeof timer.unref === 'function') {
timer.unref();
}
});
return this._Promise.race([timeoutPromise, promise]);
}
Expand Down Expand Up @@ -402,8 +407,12 @@ class Pool extends EventEmitter {
this._scheduledEviction = setTimeout(() => {
this._evict();
this._scheduleEvictorRun();
}, this._config.evictionRunIntervalMillis).unref();
}
}, this._config.evictionRunIntervalMillis);

// Only relevant in Node.js and for process quitting
if (typeof this._scheduledEviction.unref === 'function') {
this._scheduledEviction.unref();
}
}

_descheduleEvictorRun() {
Expand Down