Skip to content

Conversation

willothy
Copy link

@willothy willothy commented Apr 20, 2025

No description provided.

@willothy willothy force-pushed the hint-popup branch 2 times, most recently from 202f6a3 to 097bbc9 Compare April 20, 2025 21:10
@Xuyuanp
Copy link
Contributor

Xuyuanp commented Apr 21, 2025

Thanks for your contributing.

The basic functions are not stable yet, and there are still many modifications in progress. PRs are welcome, but it is not the best time to merge. We will review this PR later.

@willothy
Copy link
Author

willothy commented Apr 21, 2025

I've been talking with @tris203 about this on discord, he's planning on merging tomorrow afaik alongside #2

@tris203
Copy link
Collaborator

tris203 commented Apr 21, 2025

I do like the way this looks

image-3.png

@Xuyuanp
Copy link
Contributor

Xuyuanp commented Apr 21, 2025

I'm fine with this.

We need to note that the shortcut key for the Accept action is configurable

@@ -130,6 +131,27 @@ function M._display_next_suggestion(edits, ns_id)
ui.preview_winnr = preview_winnr
end

local hint_bufnr = vim.api.nvim_create_buf(false, true)
vim.api.nvim_buf_set_lines(hint_bufnr, 0, -1, false, { " ⇥ Accept" })
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the keymap is set in config should we adapt to different preferences

Although I'm not sure of the best way to adapt to this. So maybe this fine as-is for now

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, not really sure here - let me know what you want there or feel free to push changes to this branch if you have an idea.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a vim.g.nesicon or default

We should work out a naming convention for these options

@willothy
Copy link
Author

Gonna drop this back to draft status, I'm pretty busy with work this week but I'll update this and fix/add tests this weekend :)

@willothy willothy marked this pull request as draft April 22, 2025 20:49
@tris203 tris203 mentioned this pull request May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants