-
Notifications
You must be signed in to change notification settings - Fork 10
feat: add hint popup #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
202f6a3
to
097bbc9
Compare
Thanks for your contributing. The basic functions are not stable yet, and there are still many modifications in progress. PRs are welcome, but it is not the best time to merge. We will review this PR later. |
I'm fine with this. We need to note that the shortcut key for the Accept action is configurable |
@@ -130,6 +131,27 @@ function M._display_next_suggestion(edits, ns_id) | |||
ui.preview_winnr = preview_winnr | |||
end | |||
|
|||
local hint_bufnr = vim.api.nvim_create_buf(false, true) | |||
vim.api.nvim_buf_set_lines(hint_bufnr, 0, -1, false, { " ⇥ Accept" }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the keymap is set in config should we adapt to different preferences
Although I'm not sure of the best way to adapt to this. So maybe this fine as-is for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, not really sure here - let me know what you want there or feel free to push changes to this branch if you have an idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a vim.g.nesicon
or default
We should work out a naming convention for these options
Gonna drop this back to draft status, I'm pretty busy with work this week but I'll update this and fix/add tests this weekend :) |
No description provided.