Partial sign transactions *after* modifying them#4312
Open
steveluscher wants to merge 1 commit intocoral-xyz:masterfrom
Open
Partial sign transactions *after* modifying them#4312steveluscher wants to merge 1 commit intocoral-xyz:masterfrom
steveluscher wants to merge 1 commit intocoral-xyz:masterfrom
Conversation
steveluscher
force-pushed
the
correct-modify-sign-ordering
branch
from
dbf9bb8 to
ac668b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the event that the fee payer or the blockhash gets changed in
prepareTransaction(), doing so will immediately invalidate the signatures made one block earlier. Sign as late as possible.