Skip to content

fix(collectibles): stabilize Solana NFT ordering by mint address #4386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RustyCoderX wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix(collectibles): stabilize Solana NFT ordering by mint address #4386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ced062
fix(collectibles): stabilize ordering by mint address
RustyCoderX Jan 16, 2026
a78fe8c
fix(collectibles): stabilize ordering by mint address
RustyCoderX Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/data-components/src/components/Collectibles/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,9 @@ function _Collectibles({
const groupedCollectibles = useMemo(
() =>
getGroupedCollectibles(
data?.wallet?.nfts?.edges.map((e) => e.node) ?? []
(data?.wallet?.nfts?.edges.map((e) => e.node) ?? []).sort((a, b) =>
a.address.localeCompare(b.address)
)
),
[data]
);
Expand Down
16 changes: 11 additions & 5 deletions packages/data-components/src/components/Collectibles/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ export function getGroupedCollectibles(
.reduce<CollectibleGroup[]>((acc, curr) => {
acc.push({
collection: curr[0],
data: curr[1],
data: curr[1].sort((a, b) => a.address.localeCompare(b.address)),
whitelisted: curr[1][0].whitelisted,
});
return acc;
Expand All @@ -46,10 +46,16 @@ export function getGroupedCollectibles(
else if (b.collection === "Mad Lads") return 1;
else if (a.collection === "Tensorians") return -1;
else if (b.collection === "Tensorians") return 1;
else if (a.whitelisted && b.whitelisted)
return b.data.length - a.data.length;
else if (a.whitelisted) return -1;
else if (a.whitelisted && b.whitelisted) {
if (b.data.length !== a.data.length) {
return b.data.length - a.data.length;
}
return a.collection.localeCompare(b.collection);
} else if (a.whitelisted) return -1;
else if (b.whitelisted) return 1;
return b.data.length - a.data.length;
if (b.data.length !== a.data.length) {
return b.data.length - a.data.length;
}
return a.collection.localeCompare(b.collection);
});
}