Fix OpenTelemetry attribute errors for NOT_GIVEN values#18
Open
ryanlewis wants to merge 1 commit intocoralogix:masterfrom
Open
Fix OpenTelemetry attribute errors for NOT_GIVEN values#18ryanlewis wants to merge 1 commit intocoralogix:masterfrom
ryanlewis wants to merge 1 commit intocoralogix:masterfrom
Conversation
Filter out OpenAI's NOT_GIVEN sentinel values from span attributes to prevent OpenTelemetry validation errors. The library was attempting to set attributes with NOT_GIVEN type, which OpenTelemetry doesn't accept (only supports basic types: bool, str, bytes, int, float). Changes: - Update span_builder to filter NOT_GIVEN alongside None values - Add test to verify NOT_GIVEN values are properly filtered - Ensure backwards compatibility with existing attribute handling Fixes errors like: "Invalid type NotGiven for attribute 'gen_ai.request.temperature' value. Expected one of ['bool', 'str', 'bytes', 'int', 'float'] or a sequence of those types"
ryanlewis
force-pushed
the
fix/not-given-opentelemetry-attributes
branch
from
bc1e700 to
592e364
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed OpenTelemetry attribute errors that occur when NOT_GIVEN values are passed to spans.