Conversation
rtimush
reviewed
Oct 24, 2025
ocombe
force-pushed
the
fix/npm-package-fixes
branch
from
ef6ffba to
00fcb0b
Compare
rtimush
approved these changes
Oct 24, 2025
Collaborator
rtimush
left a comment
rtimush
left a comment
There was a problem hiding this comment.
Looks good to me, but let's wait for @cx-shahar-kazaz'r review as well.
ocombe
force-pushed
the
fix/npm-package-fixes
branch
2 times, most recently
from
c3213d9 to
44b9a52
Compare
- Update Node.js version from 20 to 22 in CI - Update pnpm version from 8 to 10 in CI - Replace node-fetch with built-in fetch API - Prefix all Node.js core modules with 'node:' protocol - Extract platform/arch checks into isPlatform() utility function - Use parseArgs() for CLI argument parsing - Extract localhost validation into isLocalhost() function - Remove node-fetch dependency from package.json
ocombe
force-pushed
the
fix/npm-package-fixes
branch
from
44b9a52 to
7d83661
Compare
cx-shahar-kazaz
approved these changes
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.