refactor: split release job into independent jobs in separate workflow#175
refactor: split release job into independent jobs in separate workflow#175
Conversation
workflow - Extract release jobs from ci.yml to new release.yml workflow - Split monolithic release into 4 independent jobs (cargo, 2x npm, github) - Use workflow_call for explicit release triggering from CI - Enable parallel execution and individual job retry on failure
There was a problem hiding this comment.
💡 Codex Review
protofetch/.github/workflows/ci.yml
Lines 189 to 193 in 0bed3a6
The build job now uploads artifacts as protofetch_${{ matrix.target.rust }} but the subsequent test-npm-package job still requests package-${{ matrix.os.platform }}. actions/download-artifact@v4 will fail to find a matching artifact for every matrix entry, so the npm tests can no longer run. The artifact names should be aligned with the new prefix before merging.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@ocombe I'm using 2 different tokens |
Uh oh!
There was an error while loading. Please reload this page.