Skip to content

refactor: split release job into independent jobs in separate workflow#175

Merged
rtimush merged 8 commits intomasterfrom
refactor-release-workflow
Nov 10, 2025
Merged

refactor: split release job into independent jobs in separate workflow#175
rtimush merged 8 commits intomasterfrom
refactor-release-workflow

Conversation

@cx-shahar-kazaz
Copy link
Contributor

@cx-shahar-kazaz cx-shahar-kazaz commented Nov 6, 2025

  • Extract release jobs from ci.yml to new release.yml workflow
  • Split monolithic release into 4 independent jobs (cargo, 2x npm, github)
  • Use workflow_call for explicit release triggering from CI
  • Enable parallel execution and individual job retry on failure
  • Use checkout v4

  workflow

  - Extract release jobs from ci.yml to new release.yml workflow
  - Split monolithic release into 4 independent jobs (cargo, 2x npm,
   github)
  - Use workflow_call for explicit release triggering from CI
  - Enable parallel execution and individual job retry on failure
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

- name: Download artifacts
uses: actions/download-artifact@v4
with:
name: package-${{ matrix.os.platform }}
path: artifacts

P0 Badge Update npm test job to download renamed artifacts

The build job now uploads artifacts as protofetch_${{ matrix.target.rust }} but the subsequent test-npm-package job still requests package-${{ matrix.os.platform }}. actions/download-artifact@v4 will fail to find a matching artifact for every matrix entry, so the npm tests can no longer run. The artifact names should be aligned with the new prefix before merging.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Contributor

@ocombe ocombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good but I have my doubts on the npm token working for both names

@cx-shahar-kazaz
Copy link
Contributor Author

@ocombe I'm using 2 different tokens

@rtimush rtimush merged commit 9085141 into master Nov 10, 2025
20 checks passed
@rtimush rtimush deleted the refactor-release-workflow branch November 10, 2025 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants