chore: Keep directory tree traversal in one place#188
Merged
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
smosca-coralogix
approved these changes
Jan 12, 2026
rtimush
force-pushed
the
push-upvvoornutor
branch
from
fdb15ff to
7d34c9c
Compare
rtimush
force-pushed
the
push-upvvoornutor
branch
from
7d34c9c to
8ff62a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be now reason why collecting proto files for a directory is done in two phases (first, iterating through the top-level directories, and then listing each directory recursively). We can as well start the recursion from the top-level directory directly.
This is technically a breaking change, as it means top-level proto files will be also included, when they previously were not. I don't think having to-level protos is common though though, and if someone does it I don't think protofetch should be the limiting factor.