fix(experimental/seclang): resolve golangci-lint failures in parser_v2#1501
Merged
fzipi merged 3 commits intofeature/experimental-seclangfrom Feb 28, 2026
Merged
fix(experimental/seclang): resolve golangci-lint failures in parser_v2#1501fzipi merged 3 commits intofeature/experimental-seclangfrom
fzipi merged 3 commits intofeature/experimental-seclangfrom
Conversation
5 tasks
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
Co-authored-by: fzipi <3012076+fzipi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Implement TypeConverter for SecLang parser
fix(experimental/seclang): resolve golangci-lint failures in parser_v2
Feb 27, 2026
fzipi
approved these changes
Feb 27, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/experimental-seclang #1501 +/- ##
=============================================================
Coverage 82.24% 82.25%
=============================================================
Files 176 176
Lines 9228 9229 +1
=============================================================
+ Hits 7590 7591 +1
Misses 1324 1324
Partials 314 314
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four lint violations introduced in the experimental ANTLR4 parser were breaking CI (
golangci-lintvia gocritic + unused checks).Changes
const maxIncludeRecursion— declared but never referencedParser.includeCountfield — never read or writtentypeConverter.errorsfield — never populated or consumedappendAssign(gocritic) — replace single-line cross-sliceappendwith two-statement form so the result is assigned back to the same slice variable:🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.