Fix Satoshi getCurrentValidators when --rpc.gascap=0#67
Merged
zfliex924 merged 2 commits intobranch_v1.0.17from Jun 4, 2025
Merged
Fix Satoshi getCurrentValidators when --rpc.gascap=0#67zfliex924 merged 2 commits intobranch_v1.0.17from
zfliex924 merged 2 commits intobranch_v1.0.17from
Conversation
… global gascap is 0 (#30474) In #27720, we introduced RPC global gas cap. A value of `0` means an unlimited gas cap. However, this was not the case for simulated calls. This PR fixes the behaviour.
ziogaschr
force-pushed
the
fix/satoshi_getCurrentValidators
branch
from
6c98eb0 to
8a369f5
Compare
Contributor
Author
|
I force-pushed a change as @ggcore0 found that a similar fix exists on the upstream BSC. |
charles2023wood
requested changes
Jun 3, 2025
Contributor
charles2023wood
left a comment
charles2023wood
left a comment
There was a problem hiding this comment.
It's better to fix the same problem in func (api *BlockChainAPI) SimulateV1
Contributor
Author
|
Great catch @charles2023wood |
Similar to #30474.
Contributor
Author
|
Done @charles2023wood |
charles2023wood
approved these changes
Jun 4, 2025
zfliex924
approved these changes
Jun 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #65