applib/graphics: Add support for mixed RTL-LTR text support#793
Merged
jplexer merged 1 commit intocoredevices:mainfrom Feb 6, 2026
Merged
applib/graphics: Add support for mixed RTL-LTR text support#793jplexer merged 1 commit intocoredevices:mainfrom
jplexer merged 1 commit intocoredevices:mainfrom
Conversation
…ifying and switching Signed-off-by: Elad Dvash <e.d.dvash@gmail.com>
jplexer
approved these changes
Feb 6, 2026
gmarull
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds proper handling for mixed RTL (Hebrew/Arabic) and LTR (English) text on the same line.
How It Works
Splits text into segments based on script direction and renders each appropriately - RTL segments get reversed, LTR renders normally.
Testing
Tested with the timeline_pins_demo notifications using various Hebrew, English, and mixed strings.
Also tested with Arabic but I am missing the font support for them so I couldn't check the text itself but it showed the same issues as the hebrew ones before the fixes.
This was tested in QEMU on snowy, still needs testing on actual devices
Before - Mixed in same line - English & Numericals broken, Hebrew fine:
After:
Before - Multi line English and Hebrew - English broken, Hebrew fine:
After:
AI Disclosure
This was coded with help from claude code opus 4.5