fw/popups/notifications/window: fix crash due to cross-app free#827
Merged
gmarull merged 1 commit intocoredevices:mainfrom Feb 13, 2026
Merged
fw/popups/notifications/window: fix crash due to cross-app free#827gmarull merged 1 commit intocoredevices:mainfrom
gmarull merged 1 commit intocoredevices:mainfrom
Conversation
If a notification was received (KernelMain) while viewing a notification from the notifications app, a cross-app free would occur because the prv_do_notification_vibe() call gets the current item from the swap layer (allocated by app), UUID would not match, causing a swap layer reload and so a timeline_item_destroy, freeing app-heap memory. Fixes FIRM-1322 Signed-off-by: Gerard Marull-Paretas <gerard@teslabs.com>
jplexer
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a notification was received (KernelMain) while viewing a notification from the notifications app, a cross-app free would occur because the prv_do_notification_vibe() call gets the current item from the swap layer (allocated by app), UUID would not match, causing a swap layer reload and so a timeline_item_destroy, freeing app-heap memory.
Fixes FIRM-1322