Conversation
gmarull
requested changes
Feb 23, 2026
Member
gmarull
left a comment
gmarull
left a comment
There was a problem hiding this comment.
Signed-off-by requires valid username/mail
cyrusagent
bot
force-pushed
the
cyrus/firm-1380-disable-timeline-quick-view-on-getafix-and-spalding_gabbro
branch
from
e23eb8a to
793f5bf
Compare
Timeline Quick View (Peek) is not optimized for these boards yet. Remove HAS_TIMELINE_PEEK capability from spalding_gabbro and getafix_evt/getafix_dvt board definitions to disable the feature at compile time. Fixes FIRM-1380 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Joshua Jun <joshuajun@proton.me>
cyrusagent
bot
force-pushed
the
cyrus/firm-1380-disable-timeline-quick-view-on-getafix-and-spalding_gabbro
branch
from
793f5bf to
9bdc88d
Compare
gmarull
approved these changes
Feb 23, 2026
gmarull
deleted the
cyrus/firm-1380-disable-timeline-quick-view-on-getafix-and-spalding_gabbro
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disables Timeline Quick View (Peek) on Getafix and Spalding_Gabbro boards, as the feature is not optimized for these platforms yet.
Changes
HAS_TIMELINE_PEEKcapability fromspalding_gabbroboard definitionHAS_TIMELINE_PEEKcapability fromgetafix_evt/getafix_dvtboard definitionsThis causes
CAPABILITY_HAS_TIMELINE_PEEKto be set to0at compile time for these boards, disabling all timeline peek code which is gated behind#if CAPABILITY_HAS_TIMELINE_PEEKpreprocessor conditionals.Testing
HAS_TIMELINE_PEEKis removed from target boards onlyLinear Issue
Fixes FIRM-1380