feat: add support for service-specific labels#250
Open
v4l3nt1tx wants to merge 5 commits intocoredns:masterfrom
Open
feat: add support for service-specific labels#250v4l3nt1tx wants to merge 5 commits intocoredns:masterfrom
v4l3nt1tx wants to merge 5 commits intocoredns:masterfrom
Conversation
added 4 commits
February 10, 2026 17:36
Signed-off-by: Valentin Thomas <valentinthomas@Valentins-MacBook-Pro.local>
Signed-off-by: Valentin Thomas <valentinthomas@Valentins-MacBook-Pro.local>
Signed-off-by: Valentin Thomas <valentinthomas@Valentins-MacBook-Pro.local>
Signed-off-by: Valentin Thomas <valentinthomas@Valentins-MacBook-Pro.local>
v4l3nt1tx
changed the title
Signed-off-by: Valentin Thomas <valentinthomas@Valentins-MacBook-Pro.local>
mrueg
reviewed
Feb 10, 2026
| name: {{ default (include "coredns.fullname" .) .Values.service.name }} | ||
| namespace: {{ .Release.Namespace }} | ||
| labels: {{- include "coredns.labels" . | nindent 4 }} | ||
| {{- if .Values.customLabels }} |
Author
There was a problem hiding this comment.
Because it is directly merged in the helpers in the coredns.service.labels template https://github.com/coredns/helm/pull/250/changes#diff-66b1ea94bd58fba716f9bc62273485fe77cfc6ef9dd249a8acbf7888117f11f3R242
Is this ok for you @mrueg ?
Author
|
Are you waiting for some other informations @mrueg ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this pull request needed and what does it do?
This PR adds support for service-specific labels to the CoreDNS Helm chart:
The implementation introduces a new coredns.service.labels value that properly merges service.labels with customLabels, ensuring predictable label precedence and avoiding conflicts.
All changes are fully backward compatible with existing configurations.
Checklist:
Changes are automatically published when merged to
main. They are not published on branches.Note on DCO
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.