Update will fail if update metadata is missing for the current boot type #1039
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly implements the desired behavior of failing an update when the metadata for the current boot type is missing. The changes in src/bios.rs and src/efi.rs are clear and effective. The test case in tests/kola/test-bootupd has also been updated to reflect this new behavior for BIOS-booted systems. I've added one suggestion to make the test more robust by making it boot-aware, so it can validate the behavior on both EFI and BIOS systems.
HuijingHei
force-pushed
the
fix-update
branch
from
ef6b96c to
5c6efd7
Compare
HuijingHei
force-pushed
the
fix-update
branch
3 times, most recently
from
c83c64a to
d1fa7ad
Compare
| get_component_update(sysroot, self) | ||
| let content_metadata = get_component_update(sysroot, self)?; | ||
| // Failed as expected if booted with BIOS and no update metadata | ||
| if content_metadata.is_none() && !sysroot.exists("sys/firmware/efi")? { |
There was a problem hiding this comment.
why not !is_efi_booted instead of testing the /sys path?
There was a problem hiding this comment.
I am concern that it might be not suitable for ppc, as is_efi_booted() is for x86_64, or maybe it is better to move is_efi_booted() out of efi.rs. WDYT?
2 participants
Fixes #1035