Skip to content

fix(boot_device): require LUKS methord when boot_device.luks.device is set#597

Merged
Roshan-R merged 2 commits intocoreos:mainfrom
Roshan-R:fix/issue-560
May 5, 2025
Merged

fix(boot_device): require LUKS methord when boot_device.luks.device is set#597
Roshan-R merged 2 commits intocoreos:mainfrom
Roshan-R:fix/issue-560

Conversation

@Roshan-R
Copy link
Copy Markdown
Contributor

Closes #560

Copy link
Copy Markdown
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. Should just need a small entry in the release notes.

@Roshan-R
Copy link
Copy Markdown
Contributor Author

Roshan-R commented May 2, 2025

where should the entry be under, bug fixes or misc. changes

@travier
Copy link
Copy Markdown
Member

travier commented May 5, 2025

Let's add it to bugfix.

@Roshan-R Roshan-R merged commit 87b1939 into coreos:main May 5, 2025
7 checks passed
@travier
Copy link
Copy Markdown
Member

travier commented May 5, 2025

You've added the notes to a previous release. I'll make a PR to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configs with a boot_device.luks.device set but no method (tpm2, tang, etc.) set should fail validation

2 participants