feat: add validation to merged local/inline configs#602
Conversation
travier
left a comment
There was a problem hiding this comment.
Mostly LGTM. A couple of small changes.
|
Can you also copy this validation code to all stable specs? See #476 (comment):
|
I have done the backporting to all the versions except v1 since It does not have this feature |
|
Thank you for working on this; these changes make sense to me, and LGTM, one small nit, not needed but would be nice. The other nit is can we maybe cleanup the commit history a bit, i.e squash redundancies. |
Validate Ignition configs that are embedded directly in Butane configs, either as inline content or local file references.
|
Commits have been squashed and all requested changes have been addressed. |
prestist
left a comment
There was a problem hiding this comment.
Thank you for doing this; it lgtm well done!
Closes #275