Properly feature gate rustix-based functions #75
Conversation
|
I've ensured that compilation succeeds, but was unable to run the test suite as I don't have access to a Windows machine at the moment. |
cgwalters
left a comment
cgwalters
left a comment
There was a problem hiding this comment.
Thanks for the patch. It should be easy to add a GHA Windows build test here, I can help.
korrat
force-pushed
the
korrat/push-wvxqwumulwuz
branch
from
4f25e44 to
8687bfc
Compare
|
I did #76 - you can cherry pick that commit into here if you want, or we can merge it over red and then verify this fixes it after you rebase. |
korrat
force-pushed
the
korrat/push-wvxqwumulwuz
branch
2 times, most recently
from
19cf4d6 to
1c7c77e
Compare
Since we regressed here recently.
korrat
force-pushed
the
korrat/push-wvxqwumulwuz
branch
from
1c7c77e to
c8df0c4
Compare
| assert!(td.remove_all_optional(p).unwrap()); | ||
| td.symlink("linkdest", p)?; | ||
| assert!(td.remove_all_optional(p).unwrap()); | ||
| #[cfg(not(windows))] |
There was a problem hiding this comment.
Kind of curious why you picked not(windows) vs unix here.
There was a problem hiding this comment.
Because symlink is also gated as not(windows). But could be changed to unix. Not sure whether that would change Mac coverage.
korrat
force-pushed
the
korrat/push-wvxqwumulwuz
branch
2 times, most recently
from
454425b to
1ea3233
Compare
korrat
force-pushed
the
korrat/push-wvxqwumulwuz
branch
from
1ea3233 to
c28d722
Compare
|
I have no idea why the test fails. Maybe someone can help debug on Windows? |
|
Yes no worries, you've done a lot of work here. Thanks! |
Until we can debug what the issue might be. It looks to me like the `tempfile` crate has special logic here https://github.com/Stebalien/tempfile/blob/0657fdf24925287e6d5544d9e321a48d7ceaafdc/src/file/imp/windows.rs#L92 But we're just relying on cap-std, and we need to dig to see if there's something similar or it needs changes.
|
Thanks, contributing has been a great experience! |
|
Awesome 😄 And thank you for the patch! |
2 participants
As described in #74,
cap-std-ext v4.0.2onwards do not build for Windows.This PR fixes the problems introduced in
v4.0.3, where arustix-based API was improperly feature gated.Additionally, the
noxdevconfig forCapStdExtDirExt::walkseems unsupported under Windows so far and has been disabled there.Fixes #74.