Skip to content

[ppc64le] Use XICS Interrupt Controller #3898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ravanelli merged 1 commit into from
Oct 24, 2024
Merged

[ppc64le] Use XICS Interrupt Controller #3898

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mantle/platform/qemu.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1398,8 +1398,8 @@ func baseQemuArgs(arch string, memoryMiB int) ([]string, error) {
ret = []string{
"qemu-system-ppc64",
// kvm-type=HV ensures we use bare metal KVM and not "user mode"
// https://qemu.readthedocs.io/en/latest/system/ppc/pseries.html#switching-between-the-kvm-pr-and-kvm-hv-kernel-module
"-machine", "pseries,kvm-type=HV," + machineArg,
// https://www.qemu.org/docs/master/system/ppc/pseries.html
"-machine", "pseries,kvm-type=HV,ic-mode=xics," + machineArg,
Copy link
Member

@ravanelli ravanelli Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify why not use XIVE? Or it is suppose to work only with LPARs?
Seems XICS is for P8 and and XIVE for P9 and P10?

Copy link

@vaibhav92 vaibhav92 Oct 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For KVM-HV hypervisor running in a pseries-guest native xive mode is currently not supported, but rather native xics.
Qemu by default will attempt enabling native xive for pseries guests first and if that fails , fallsback to xics based interrupts hence this warning is emitted.

Explicitly asking Qemu to use xics base interrupt controller forces qemu to not attempt to use XIVE interrupt controller preventing this warning message from being emmited.

Copy link
Member

@ravanelli ravanelli Oct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for the clarification @vaibhav92!
LGTM!

}
default:
return nil, fmt.Errorf("architecture %s not supported for qemu", arch)
Expand Down
Loading