Skip to content

grub.cfg: Remove grub.cfg in bootupd favor #3900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlebon merged 1 commit into from
Oct 17, 2024
+0 −96
Merged

grub.cfg: Remove grub.cfg in bootupd favor #3900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/cosalib/cmdlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,9 +447,6 @@ def generate_image_json(srcfile):
r = yaml.safe_load(open("/usr/lib/coreos-assembler/image-default.yaml"))
for k, v in flatten_image_yaml(srcfile).items():
r[k] = v
# Serialize our default GRUB config
with open("/usr/lib/coreos-assembler/grub.cfg") as f:
r['grub-script'] = f.read()
Comment on lines -450 to -452
Copy link
Member

@dustymabe dustymabe Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, just to confirm 100% - this definitely isn't used anywhere?

Copy link
Member Author

@ravanelli ravanelli Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not find any other place using it, looking at c9036fa it was needed for create_disk, what makes sense. So, I will say no

return r


Expand Down
93 changes: 0 additions & 93 deletions src/grub.cfg
View file
Open in desktop

This file was deleted.

Loading