Inject oci-image in release metadata and oci-images in release index
#3919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
Member
Author
|
Requires: coreos/stream-metadata-go#75 |
To pick up the stream-metadata-go bump in the previous commit. But also this cleans up a bunch of other unrelated stuff.
No functional change. Prep for next patch.
Take the digest pullspec for the base OS bootable container and put it in the new `oci-image` field in the release metadata. Part of coreos/fedora-coreos-tracker#1823.
Currently, that function operates directly on an S3 bucket. This makes it harder to test locally. Add a new `--local-mode` option in which we expect to be in a cosa workdir with release metadata present and a release index. This is mostly peppering conditionals in the code. Patch best viewed with whitespace ignored.
When updating the release index, gather the OCI pullspecs across all arches for a given release into a single list and inject it into the new `oci-images` key, the same way we do for OSTree commits and `commits`. Part of coreos/fedora-coreos-tracker#1823.
jlebon
force-pushed
the
pr/fcos-metadata-bits
branch
from
321cccf to
195ef6e
Compare
Member
Author
|
Updated and out of draft! Now with the stream-metadata-go bump to pull in coreos/stream-metadata-go#75. |
Contributor
|
This broke SCOS for OKD.specifically the assert in 5900ba1 fails |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Part of coreos/fedora-coreos-tracker#1823.