cmd-cloud-prune: Refactor to iterate by build, arch, then action #3928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gursewak1997
force-pushed
the
refactor-gc-code
branch
from
317b390 to
2541712
Compare
dustymabe
approved these changes
Nov 12, 2024
Member
dustymabe
left a comment
dustymabe
left a comment
There was a problem hiding this comment.
trivial LGTM
A few questions/suggestions on the code as I was going through.
src/cmd-cloud-prune
Outdated
| policy_cleanup = build.setdefault("policy-cleanup", {}) | ||
| action_duration = convert_duration_to_days(policy[stream][action]) | ||
| ref_date = today_date - relativedelta(days=int(action_duration)) | ||
| images_to_keep = policy.get(stream, {}).get("images-keep", []) |
Member
There was a problem hiding this comment.
images_to_keep should be the same for all runs of these loops, right? if so we can move the variable definition to the outside of these loops.
src/cmd-cloud-prune
Outdated
| # Iterate through builds from oldest to newest | ||
| for build in reversed(builds): | ||
| build_id = build["id"] | ||
| (build_date, _) = parse_fcos_version_to_timestamp_and_stream(build_id) |
Member
There was a problem hiding this comment.
are the outer parentheses required here?
Suggested change
| (build_date, _) = parse_fcos_version_to_timestamp_and_stream(build_id) | |
| build_date, _ = parse_fcos_version_to_timestamp_and_stream(build_id) |
dustymabe
requested changes
Nov 12, 2024
Member
dustymabe
left a comment
dustymabe
left a comment
There was a problem hiding this comment.
oh actually. if you look at the commit title it is wrong:
overrides: Pin kdump-utils-1.0.48-1.fc42 for ppc64le
Reorganized the loop structure to iterate over builds first, followed by arch and then actions, optimizing the number of meta.json downloads and reducing redundancy.
gursewak1997
force-pushed
the
refactor-gc-code
branch
from
2541712 to
ff8a909
Compare
Member
Author
|
/test rhcos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganized the loop structure to iterate over builds first, followed by arch and then actions, optimizing the number of meta.json downloads and reducing redundancy.