tests: update podman.workflow and remove fcos.internet #3939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test has been denylisted in FCOS due to rate limiting issues with the nginx container, causing frequent timeouts and failures. Replace the nginx container with the `fedora:latest` container from quay.io to mitigate this. Also modify the `podman run` command to start a Python HTTP server to continue testing volume mounting and port forwarding.
dustymabe
reviewed
Nov 13, 2024
This test has been denylisted in FCOS for a long time due to rate limiting issues with the busybox container. The functionality of the test is covered by other FCOS tests so it can be removed. Also remove some older, obsolete functions that were probably a part of this test in the past. see: https://issues.redhat.com/browse/COS-2094
dustymabe
approved these changes
Nov 14, 2024
marmijo
added a commit
to marmijo/fedora-coreos-config
that referenced
this pull request
Nov 14, 2024
dustymabe
pushed a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Nov 15, 2024
marmijo
added a commit
to marmijo/coreos-assembler
that referenced
this pull request
Nov 19, 2024
Bump the retry delay to `10*time.Seconds` which doubles the previous delay to allow for enough time to report success. Update the container name in an error statement from nginx to Fedora which should have been done in coreos#3939 fixes: coreos/fedora-coreos-tracker#1835
dustymabe
pushed a commit
that referenced
this pull request
Nov 20, 2024
Bump the retry delay to `10*time.Seconds` which doubles the previous delay to allow for enough time to report success. Update the container name in an error statement from nginx to Fedora which should have been done in #3939 fixes: coreos/fedora-coreos-tracker#1835
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two tests have been denylisted in FCOS for quite some time due to rate limiting issues with the containers they are pulling.
For
podman.workflow: use thequay.io/fedora/fedoracontainer and a Python HTTP server instead of the nginx container.For
fcos.internet: remove it altogether as there are other tests within FCOS that test this functionality.See: https://issues.redhat.com/browse/COS-2094