Fix --skip-config-archive.

[mtalexan]

The --skip-config-archive skips creating the tar.gz of the src/config. However the changes to how files are collected failed to check this before hardcoding that the output file should be collected.

---

Looks like when the rework happened to use loose_objs, it missed the fact that the config archive may or may not exist. If the --skip-config-archive is used, the build currently fails during the collection step.

/close #3972

[openshift-ci]

Hi @mtalexan. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mtalexan]

You can see on line 292 that it's disabling generation of the file when --skip-config-archive is enabled, which means the file won't be present to collect.

Prior to the loose_objs rework, everything in a location was moved so this file being missing didn't matter. Now it's called out explicitly but may or may not exist.

[jlebon]

Thanks for the fix!

[jlebon]

/ok-to-test