cmd-import: also populate coreos-assembler.config-gitrev

[jlebon]

This is older than coreos-assembler.container-config-git and is used in various places in the pipeline/CI.

[gemini-code-assist]

Code Review

This pull request correctly adds the coreos-assembler.config-gitrev metadata field during OCI image import, ensuring compatibility with older pipeline components. The change is straightforward and well-implemented. I have one suggestion to improve maintainability by replacing magic strings for dictionary keys with constants.

[gemini-code-assist]

To improve maintainability and avoid potential typos from magic strings, consider defining the dictionary keys used here as constants. This is particularly useful for keys that are part of a specification (like OCI labels) or are shared across different parts of the codebase.

You could define them at the top of the file, for example:

# OCI image spec labels
OCI_LABEL_SOURCE = 'org.opencontainers.image.source'
OCI_LABEL_REVISION = 'org.opencontainers.image.revision'

# COSA metadata keys
COSA_META_CONTAINER_CONFIG_GIT = 'coreos-assembler.container-config-git'
COSA_META_CONFIG_GITREV = 'coreos-assembler.config-gitrev'

And then use these constants in this block:

    source = metadata.get('Labels', {}).get(OCI_LABEL_SOURCE)
    commit = metadata.get('Labels', {}).get(OCI_LABEL_REVISION)
    if source and commit:
        meta[COSA_META_CONTAINER_CONFIG_GIT] = {
            'origin': source,
            'commit': commit,
        }
        meta[COSA_META_CONFIG_GITREV] = commit

[dustymabe]

This is older than coreos-assembler.container-config-git and is used in various places in the pipeline/CI.

Does this advocate for us finding and fixing those few places rather than adding 2nd order backwards compat?

[dustymabe]

This is older than coreos-assembler.container-config-git and is used in various places in the pipeline/CI.

Does this advocate for us finding and fixing those few places rather than adding 2nd order backwards compat?

At least here is a start:

• jobs: use newer API for coreos config git rev fedora-coreos-pipeline#1203
• jobs/test-override: use newer API for coreos config git rev coreos-ci#92

[dustymabe]

• use newer API for coreos config git rev fedora-coreos-browser#55

[jlebon]

Yup, sure. Trying to fix clients SGTM too.