cmd-import: write commitmeta.json to the builds dir #4293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
PeaceRebel
force-pushed
the
pr/import-commitmeta
branch
from
5dc4169 to
b2394be
Compare
Contributor
Author
|
Linking the comment/query in the issue here: #4288 (comment) |
PeaceRebel
force-pushed
the
pr/import-commitmeta
branch
from
b2394be to
86714cf
Compare
jbtrystram
reviewed
Sep 2, 2025
Member
jbtrystram
left a comment
jbtrystram
left a comment
There was a problem hiding this comment.
Look sane to me, but i'm wondering if we need more than just the pkg list ?
Also, for reference almost the same script already exist in https://github.com/openshift/os/blob/master/scripts/generate-metadata
PeaceRebel
force-pushed
the
pr/import-commitmeta
branch
from
86714cf to
591aafb
Compare
Contributor
Author
|
Added the additional fields now. |
HuijingHei
reviewed
Sep 3, 2025
jlebon
reviewed
Sep 5, 2025
PeaceRebel
force-pushed
the
pr/import-commitmeta
branch
from
591aafb to
8d950c6
Compare
PeaceRebel
force-pushed
the
pr/import-commitmeta
branch
from
8d950c6 to
43aad35
Compare
Member
|
You should be able to drop the revert and rebase now that #4300 landed. |
PeaceRebel
force-pushed
the
pr/import-commitmeta
branch
from
43aad35 to
ce63ae4
Compare
This includes the details of packages that are included in the commit.
PeaceRebel
force-pushed
the
pr/import-commitmeta
branch
from
ce63ae4 to
b96b207
Compare
Contributor
Author
|
Fixed the python style check failure and rebased to main |
jlebon
approved these changes
Sep 8, 2025
HuijingHei
approved these changes
Sep 9, 2025
Member
|
The CI lint failure is #4254 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the details of packages that are included in the commit.
Closes: #4288