[rhcos-4.18] cmd-push-container-manifest: backport --write-digest-to-file option #4311
Conversation
- This maps to Podman's --digestfile option, allowing the manifest digest to be saved for future reference or use. Signed-off-by: Renata Ravanelli <[email protected]>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request backports the --write-digest-to-file option to the cmd-push-container-manifest command. The changes correctly add the new command-line argument and propagate it through the function calls to podman manifest push. The implementation is sound, but I've identified a couple of minor documentation issues where the docstrings for modified functions were not updated to include the new parameter. Addressing these will improve code maintainability.
|
Sorry things are changing so quickly here. I think once coreos/fedora-coreos-pipeline#1216 merges we'll be back safe again? |
ah yes, thanks ! |
3 participants
Adding the container signature in the pipeline [1] added an extra argument to the container push call.
Cherry-pick 677fe26 to add the option to unbreak the pipeline for RHCOS.
[1] coreos/fedora-coreos-pipeline@b4df2de