cmd-import: consider architecture when calculating previous build #4342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly updates cmd-import to be architecture-aware when finding the previous build to diff against. Instead of using the globally previous build, it now correctly finds the latest build for the specific architecture being imported. This change is logical and addresses the issue of architectures not being present in every build. I have one minor suggestion to improve code conciseness.
jlebon
previously approved these changes
Oct 7, 2025
|
flake8 complaining |
Not all architectures get built for every build in a stream. This is true at least for non-production streams. Let's account for that here.
dustymabe
force-pushed
the
dusty-diff-arch
branch
from
194968d to
9e07907
Compare
|
fixed |
jlebon
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all architectures get built for every build in a stream. This is true at least for non-production streams. Let's account for that here.