Skip to content

qemu.go: retry if there is a race condition to bind port 2049 #4358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+15 −2
Closed

qemu.go: retry if there is a race condition to bind port 2049 #4358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions mantle/platform/qemu.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -645,11 +645,24 @@ func (builder *QemuBuilder) setupNetworking() error {
address := fmt.Sprintf(":%d", builder.requestedHostForwardPorts[i].HostPort)
// Possible race condition between getting the port here and using it
// with qemu -- trade off for simpler port management
l, err := net.Listen("tcp", address)
var l net.Listener
var err error
const maxRetries = 12
const retryDelay = 5 * time.Second
for attempt := 1; attempt <= maxRetries; attempt++ {
l, err = net.Listen("tcp", address)
if err == nil {
l.Close()
break
}

fmt.Printf("Failed to listen on %s: %v, retrying (%d/%d)...\n",
address, err, attempt, maxRetries)
time.Sleep(retryDelay)
}
if err != nil {
return err
}
l.Close()
builder.requestedHostForwardPorts[i].HostPort = l.Addr().(*net.TCPAddr).Port
netdev += fmt.Sprintf(",hostfwd=tcp:127.0.0.1:%d-:%d",
builder.requestedHostForwardPorts[i].HostPort,
Expand Down
Loading