tests/ostree.sync: tag with "reprovision" #4361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a race condition between tests using the same NFS port by adding the reprovision tag to the ostree.sync test, forcing it to run serially. The change is appropriate. I have added one suggestion to include a comment in the code, which will improve maintainability by explaining the purpose of this tag.
HuijingHei
force-pushed
the
ostree-sync-reprovision
branch
from
f93a878 to
724de62
Compare
Member
Author
|
@dustymabe just tag "reprovision" to |
HuijingHei
force-pushed
the
ostree-sync-reprovision
branch
from
724de62 to
1b199ce
Compare
dustymabe
reviewed
Nov 6, 2025
Member
|
There is a race condition for `ostree.sync` and `kdump.crash.nfs` to bind port 2049, according to coreos#4117 (comment), add tag `reprovision` to force them to run serially now.
HuijingHei
force-pushed
the
ostree-sync-reprovision
branch
from
1b199ce to
16ae150
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race condition for
ostree.syncandkdump.crash.nfsto bind port 2049, according to #4117 (comment), add tagreprovisionto force it to run serially now.