mantle/kola: add remote resource fetching to fips test #4373
Conversation
This should help us catch cases like [1] where we regressed on FIPS downstream. [1] https://issues.redhat.com/browse/OCPBUGS-65684
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the FIPS test to include fetching a remote resource over HTTPS, which helps verify that TLS is working correctly in FIPS mode. The changes are logical and correctly add the necessary internet dependency tag. My main feedback is that the test doesn't explicitly verify the successful download of the remote resource. While a failure would likely cause the test to fail implicitly, adding an explicit check would make the test more robust and failures easier to diagnose. I've left a comment with more details on how this could be implemented.
|
We need to hold this until we get sorted out Ignition packages that don't have this problem. Otherwise our CI downstream is going to start failing. |
Our fips test became more strict in [1] but we need an updated ignition [2] in order for the test to pass. Let's just snooze the test until we can get that updated Ignition. [1] coreos/coreos-assembler#4373 [2] https://issues.redhat.com/browse/RHEL-129425
|
We should be able to merge this once coreos/rhel-coreos-config#104 merges. /retest |
Our fips test became more strict in [1] but we need an updated ignition [2] in order for the test to pass. Let's just snooze the test until we can get that updated Ignition. [1] coreos/coreos-assembler#4373 [2] https://issues.redhat.com/browse/RHEL-129425
|
/retest |
1 similar comment
|
/retest |
3 participants
This should help us catch cases like [1] where we regressed on FIPS downstream.
[1] https://issues.redhat.com/browse/OCPBUGS-65684