Revert "Fix CI E1101 error" #4382
Merged
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 4484b11. This is causing an infinite loop (and thus a memory leak), which means our pods get OOM killed when making signing requests.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request reverts a previous commit that introduced an infinite loop and memory leak. The revert is correct and necessary to fix this critical issue. While reviewing, I identified a latent bug in the restored code. The registered_cb callback incorrectly handles the result from the DeferredList returned by twisted_consume, which would lead to an AttributeError. I have provided a comment with a code suggestion to fix this bug, ensuring the application runs correctly after the revert.
Similar to what we were already doing for addErrback.
aaradhak
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 4484b11.
This is causing an infinite loop (and thus a memory leak), which means our pods get OOM killed when making signing requests.