Skip to content

Conversation

@Rolv-Apneseth
Copy link

No description provided.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the user Rolv-Apneseth to the approvers list in the OWNERS file. The change is correct. For better long-term maintainability of the OWNERS file, I've suggested sorting the list of approvers alphabetically. This will make it easier to find users and prevent duplicates in the future.

- joelcapitao
- tlbueno
- PeaceRebel
- Rolv-Apneseth
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and make it easier to find users and prevent duplicates, please consider keeping the approvers list sorted alphabetically.

While this change is simple, sorting the list now will establish a convention for future modifications. You can replace the current list of approvers with the following sorted list:

  - aaradhak
  - c4rt0
  - cgwalters
  - cverna
  - dustymabe
  - gursewak1997
  - HuijingHei
  - jbtrystram
  - jlebon
  - jmarrero
  - joelcapitao
  - jschintag
  - lukewarmtemp
  - madhu-pillai
  - marmijo
  - mike-nguyen
  - PeaceRebel
  - prestist
  - ravanelli
  - Rolv-Apneseth
  - tlbueno
  - travier
  - yasminvalim

@Rolv-Apneseth
Copy link
Author

Should I sort the list alphabetically in this PR as per that suggestion?

Copy link
Member

@jbtrystram jbtrystram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jbtrystram jbtrystram enabled auto-merge (rebase) January 14, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants