Docs: Add osbuild to documentation
#4413
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the documentation to reflect the introduction of the osbuild command for creating images, replacing the older buildextend commands. The changes in docs/cosa.md correctly add osbuild and remove buildextend. In docs/building-fcos.md, the build process is updated to use cosa osbuild qemu. However, I've noted one issue where the cosa fetch command is removed, which will cause an error for new users. My review includes a comment to address this.
I am having trouble creating individual review comments. Click here to see my feedback.
docs/building-fcos.md (188-195)
This change removes the explicit cosa fetch step. However, cosa build will fail on a fresh checkout if cosa fetch has not been run first, leading to a "Must fetch before building" error. This will break the workflow for new users following this guide. Please consider keeping this section, or at least mentioning that cosa fetch is a prerequisite to cosa build.
|
/test ci/prow/rhcos |
|
@dustymabe: The specified target(s) for DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test rhcos |
|
NOTE: I'm running the rhcos test not because I suspect this change needs to be tested, but for another unrelated change where I want to see if CI is fixed now |
|
hmm. I think I'd prefer for the 4 commits to be combined into one with maybe each current commit title as a bullet point in the body of the commit. |
|
@angelcerveraroldan: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
jbtrystram
left a comment
jbtrystram
left a comment
There was a problem hiding this comment.
Agreed with Dusty, this should be one commit
| | ---- | ----------- | | ||
| | [buildextend-live](https://github.com/coreos/coreos-assembler/blob/main/src/cmd-buildextend-live) | Generate the Live ISO | ||
| | [buildextend-{dasd,metal,metal4k,qemu,secex}](https://github.com/coreos/coreos-assembler/blob/main/src/cmd-buildextend-metal) | Generate artifacts for the given platforms | ||
| | [buildextend-{aliyun,aws,azure,digitalocean,exoscale,gcp,vultr}](https://github.com/coreos/coreos-assembler/blob/main/src/cmd-ore-wrapper) | Generate artifacts for the given platforms | ||
| | [buildextend-{azurestack,ibmcloud,openstack,vmware}](https://github.com/coreos/coreos-assembler/blob/main/src/cmd-artifact-disk) | Generate artifacts for the given platforms | ||
| | [{aliyun,aws}-replicate](https://github.com/coreos/coreos-assembler/blob/main/src/cmd-ore-wrapper) | Replicate images on the platforms (AMIs for AWS) |
There was a problem hiding this comment.
these need to be replaced with their osbuild equivalent
3 participants
osbuildto the list of main commands, and removebuildextendcommands.cosa osbuild qemuas a step in the build docs.Closes: #4304