s390x: prepare for the upcoming 'pvimg' tool replacing 'genprotimg'#1597
Merged
nikita-dubrovskii merged 2 commits intocoreos:mainfrom Feb 6, 2025
Merged
s390x: prepare for the upcoming 'pvimg' tool replacing 'genprotimg'#1597nikita-dubrovskii merged 2 commits intocoreos:mainfrom
nikita-dubrovskii merged 2 commits intocoreos:mainfrom
Conversation
Since s390-tools commit f4cf4ae6ebb1 ("rust: Add a new tool called 'pvimg'") the
C 'genprotimg' tool no longer exists and was replaced by symlink to Rust 'pvimg create',
which by default doens't overwrite the output image.
For backward compatibility let's silently remove the 'sdboot'.
nikita-dubrovskii
force-pushed
the
pvimg
branch
from
556ea3a to
1bdec2b
Compare
travier
approved these changes
Feb 6, 2025
Member
travier
left a comment
travier
left a comment
There was a problem hiding this comment.
I only have limited context and did not test this but LGTM
Contributor
Author
No worries, i've tested it locally |
|
LGTM, thanks for taking care! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since s390-tools commit f4cf4ae6ebb1 (Remove genprotimg-C and switch to genprotimg-Rust implementation)
FCCOS/RHCOS may come with symlink to
pvimg create.New
pvimgmade some cmdline options obsolete (-V) and by default doesn't overwrite the output image (sdboot), which leads to an issue openshift/os#1731.For now keep the call to
genprotomg, even if it's symlink, but let's:sdbootbefore generating new one