signing-keys: add Fedora 45 key#1722
Conversation
We branched F44 from rawhide so rawvhide is now F45. Ref: https://src.fedoraproject.org/rpms/fedora-repos/blob/rawhide/f/RPM-GPG-KEY-fedora-45-primary
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the signing key for Fedora 45 and updates the release notes. The change is straightforward, but it appears to be incomplete. Based on the project's history, adding a new key is usually accompanied by removing the oldest one. I've suggested removing the Fedora 42 key and updating the release notes to reflect this, to maintain the key rotation policy.
docs/release-notes.md
Outdated
|
|
||
| Major changes: | ||
|
|
||
| - Add Fedora 45 signing key |
There was a problem hiding this comment.
Based on the project's key rotation policy, when a new Fedora key is added, the oldest one is typically removed. With the addition of the Fedora 45 key, the Fedora 42 key should also be removed from src/signing-keys.asc. Please update this release note to reflect that.
| - Add Fedora 45 signing key | |
| - Add Fedora 45 signing key; drop Fedora 42 signing key |
|
This is blocked on coreos/coreos-assembler#4431 |
|
Also let's fix CI here with #1724 |
2 participants
We branched F44 from rawhide so rawvhide is now F45.
Ref: https://src.fedoraproject.org/rpms/fedora-repos/blob/rawhide/f/RPM-GPG-KEY-fedora-45-primary
Tracker: coreos/fedora-coreos-tracker#2055