Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the dependencies in Cargo.lock and Cargo.toml to pre-release version 0.26.0. The updates include version bumps for various crates and the addition of new crates. I have identified a potential issue with the version range specified for ignition-config in Cargo.toml and have added a review comment.
4e177f6 to
84e6ff6
Compare
|
I think some more pins are required to keep it in the 2021 edition: diff --git a/Cargo.toml b/Cargo.toml
index e128ba3..8bb6794 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -60,7 +60,7 @@ ignition-config = ">= 0.3, < 0.7"
lazy_static = "^1.4"
libc = "^0.2"
nix = { version = ">= 0.29, < 0.30", default-features = false, features = [ "dir", "ioctl", "mount", "process", "sched", "signal", "user"] }
-nmstate = { version = ">= 2.2.3, < 3", default-features = false, features = ["gen_conf"] }
+nmstate = { version = ">= 2.2.3, < 2.2.5", default-features = false, features = ["gen_conf"] }
openssl = "^0.10"
pipe = ">= 0.3, < 0.5"
regex = ">= 1.4, < 2"
@@ -69,11 +69,11 @@ serde = { version = "^1.0", features = ["derive"] }
serde_json = "^1.0"
serde_with = ">= 1.9.4, < 4"
serde_yaml = ">= 0.8, < 0.10"
-tempfile = ">= 3.1, < 4"
+tempfile = ">= 3.1, < 3.25"
textwrap = { version = ">= 0.15.0, < 0.17.0", default-features = false }
thiserror = "2.0"
url = ">= 2.1, < 3.0"
-uuid = { version = ">= 0.8, < 2.0", features = ["v4"] }
+uuid = { version = ">= 0.8, < 1.18", features = ["v4"] }
walkdir = "^2.4"
xz2 = "^0.1"
zstd = { version = ">= 0.10.0, < 0.14.0", features = ["pkg-config"] } |
84e6ff6 to
e34d01e
Compare
|
@Rolv-Apneseth mid process of doing just that :) |
Ah, my bad |
e34d01e to
c753357
Compare
NOPE not at all lol I appreaciate the feedback! |
c753357 to
c182b5a
Compare
|
Halting due to downstream of ignition-config-rs might need an update 😞 |
Set resolver = "3" to enable MSRV-aware dependency resolution, which automatically selects dependency versions compatible with rust-version 1.85.0.
c182b5a to
bf571f2
Compare
bf571f2 to
b7185f1
Compare
|
Well.. thats werid. Its been merged but its showing it has not from this PR view but you can see the commits in main.. so I guess I am closing this. |
#1725